Skip to content

fix: Fix CodeQL issue#367

Merged
Avijit-Microsoft merged 2 commits into
devfrom
psl-pk-aiagentPlugin
Apr 16, 2025
Merged

fix: Fix CodeQL issue#367
Avijit-Microsoft merged 2 commits into
devfrom
psl-pk-aiagentPlugin

Conversation

@Pavan-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request focuses on improving error logging and response messages in the src/api/api/api_routes.py and src/api/api/history_routes.py files. The key changes include enhancing the logging of exceptions and standardizing the error messages returned in JSON responses.

Improvements to error logging and response messages:

  • src/api/api/api_routes.py: Enhanced exception logging by including the exception message in the log and standardized the error messages returned in JSON responses for multiple endpoints, such as fetch_chart_data, fetch_chart_data_with_filters, fetch_filter_data, conversation, and get_layout_config. [1] [2] [3] [4] [5]

  • src/api/api/history_routes.py: Improved exception logging by including the exception message in the log and standardized the error messages returned in JSON responses for various endpoints, including add_conversation, update_conversation, update_message_feedback, delete_conversation, list_conversations, get_conversation_messages, rename_conversation, delete_all_conversations, clear_messages, and ensure_cosmos. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

@Avijit-Microsoft Avijit-Microsoft merged commit aafbe22 into dev Apr 16, 2025
6 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Pavan-Microsoft Pavan-Microsoft deleted the psl-pk-aiagentPlugin branch April 17, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants